From: Piotr Gardocki <piotrx.gardocki@intel.com>
Date: Wed, 14 Jun 2023 14:53:00 +0000 (+0200)
Subject: net: add check for current MAC address in dev_set_mac_address
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ad72c4a06acc6762e84994ac2f722da7a07df34e;p=linux.git

net: add check for current MAC address in dev_set_mac_address

In some cases it is possible for kernel to come with request
to change primary MAC address to the address that is already
set on the given interface.

Add proper check to return fast from the function in these cases.

An example of such case is adding an interface to bonding
channel in balance-alb mode:
modprobe bonding mode=balance-alb miimon=100 max_bonds=1
ip link set bond0 up
ifenslave bond0 <eth>

Signed-off-by: Piotr Gardocki <piotrx.gardocki@intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---

diff --git a/net/core/dev.c b/net/core/dev.c
index 63abb0463c245..e4ff0adf55237 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -8781,6 +8781,8 @@ int dev_set_mac_address(struct net_device *dev, struct sockaddr *sa,
 		return -EINVAL;
 	if (!netif_device_present(dev))
 		return -ENODEV;
+	if (!memcmp(dev->dev_addr, sa->sa_data, dev->addr_len))
+		return 0;
 	err = dev_pre_changeaddr_notify(dev, sa->sa_data, extack);
 	if (err)
 		return err;