From: Roman Gushchin Date: Tue, 22 May 2018 10:10:31 +0000 (+0100) Subject: kselftest/cgroup: fix variable dereferenced before check warning X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=adb31be4424cc22f328e6664280f5c4e4902aaf3;p=linux.git kselftest/cgroup: fix variable dereferenced before check warning cg_name(const char *root, const char *name) is always called with non-empty root and name arguments, so there is no sense in checking it in the function body (after using in strlen()). Signed-off-by: Roman Gushchin Reported-by: Dan Carpenter Signed-off-by: Shuah Khan (Samsung OSG) --- diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c index 41cc3b5e5be1d..b69bdeb4b9feb 100644 --- a/tools/testing/selftests/cgroup/cgroup_util.c +++ b/tools/testing/selftests/cgroup/cgroup_util.c @@ -59,8 +59,7 @@ char *cg_name(const char *root, const char *name) size_t len = strlen(root) + strlen(name) + 2; char *ret = malloc(len); - if (name) - snprintf(ret, len, "%s/%s", root, name); + snprintf(ret, len, "%s/%s", root, name); return ret; } @@ -70,8 +69,7 @@ char *cg_name_indexed(const char *root, const char *name, int index) size_t len = strlen(root) + strlen(name) + 10; char *ret = malloc(len); - if (name) - snprintf(ret, len, "%s/%s_%d", root, name, index); + snprintf(ret, len, "%s/%s_%d", root, name, index); return ret; }