From: Yuan Can Date: Sat, 24 Sep 2022 07:03:00 +0000 (+0000) Subject: phy: qcom-qmp-usb: Use dev_err_probe() to simplify code X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=add7000bdd438c4195095dca7bff6877d54d06f4;p=linux.git phy: qcom-qmp-usb: Use dev_err_probe() to simplify code In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. Signed-off-by: Yuan Can Reviewed-by: Neil Armstrong Reviewed-by: Dmitry Baryshkov Reviewed-by: Andrew Halaney Link: https://lore.kernel.org/r/20220924070300.25080-5-yuancan@huawei.com Signed-off-by: Vinod Koul --- diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c index f01b3022a10dc..b84c0d4b57541 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c @@ -2753,12 +2753,9 @@ static int qmp_usb_probe(struct platform_device *pdev) return ret; ret = qmp_usb_vreg_init(dev, cfg); - if (ret) { - if (ret != -EPROBE_DEFER) - dev_err(dev, "failed to get regulator supplies: %d\n", - ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "failed to get regulator supplies\n"); num = of_get_available_child_count(dev->of_node); /* do we have a rogue child node ? */