From: Kent Overstreet <kent.overstreet@linux.dev>
Date: Mon, 13 Mar 2023 13:53:04 +0000 (-0400)
Subject: bcachefs: Fix stripe create error path
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=aebe7a679cbdd827769e85f632562a66d2a2b9f3;p=linux.git

bcachefs: Fix stripe create error path

If we errored out on a new stripe before fully allocating it, we
shouldn't be zeroing out unwritten data.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
---

diff --git a/fs/bcachefs/ec.c b/fs/bcachefs/ec.c
index 9ee29dac48ba6..74cfd9edd6802 100644
--- a/fs/bcachefs/ec.c
+++ b/fs/bcachefs/ec.c
@@ -1078,13 +1078,15 @@ static void ec_stripe_create(struct ec_stripe_new *s)
 
 	closure_sync(&s->iodone);
 
-	for (i = 0; i < nr_data; i++)
-		if (s->blocks[i]) {
-			ob = c->open_buckets + s->blocks[i];
+	if (!s->err) {
+		for (i = 0; i < nr_data; i++)
+			if (s->blocks[i]) {
+				ob = c->open_buckets + s->blocks[i];
 
-			if (ob->sectors_free)
-				zero_out_rest_of_ec_bucket(c, s, i, ob);
-		}
+				if (ob->sectors_free)
+					zero_out_rest_of_ec_bucket(c, s, i, ob);
+			}
+	}
 
 	if (s->err) {
 		if (!bch2_err_matches(s->err, EROFS))