From: Borislav Petkov <bp@suse.de>
Date: Thu, 18 Apr 2019 17:41:56 +0000 (+0200)
Subject: driver core: Clarify which counterparts to use to device_add()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=affada726cad2402804ec29fc000276c7dc23b95;p=linux.git

driver core: Clarify which counterparts to use to device_add()

It is not absolutely clear from the docs how the cleanup path after
device_add() should look like so spell it out explicitly.

No functional changes, just documentation.

Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 4aeaa0c92bda5..fd7511e04e622 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -1999,6 +1999,11 @@ static int device_private_init(struct device *dev)
  * NOTE: _Never_ directly free @dev after calling this function, even
  * if it returned an error! Always use put_device() to give up your
  * reference instead.
+ *
+ * Rule of thumb is: if device_add() succeeds, you should call
+ * device_del() when you want to get rid of it. If device_add() has
+ * *not* succeeded, use *only* put_device() to drop the reference
+ * count.
  */
 int device_add(struct device *dev)
 {