From: Gleb Natapov <gleb@redhat.com>
Date: Thu, 22 Oct 2009 16:43:43 +0000 (+0100)
Subject: net: use qemu_send_packet_raw() in qemu_announce_self()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b04c4134d6de28c249277de19e523bfbe4aebbd6;p=qemu.git

net: use qemu_send_packet_raw() in qemu_announce_self()

Use qemu_send_packet_raw to send gratuitous arp. This will ensure that
vnet header is handled properly.

Also, avoid sending the gratuitous packet to the guest. There doesn't
appear to be any reason for doing that and the code will currently just
crash if the NIC is not associated with a vlan.

Signed-off-by: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---

diff --git a/savevm.c b/savevm.c
index 95b77f3683..b7abf43cee 100644
--- a/savevm.c
+++ b/savevm.c
@@ -126,8 +126,6 @@ static int announce_self_create(uint8_t *buf,
 static void qemu_announce_self_once(void *opaque)
 {
     int i, len;
-    VLANState *vlan;
-    VLANClientState *vc;
     uint8_t buf[60];
     static int count = SELF_ANNOUNCE_ROUNDS;
     QEMUTimer *timer = *(QEMUTimer **)opaque;
@@ -136,10 +134,7 @@ static void qemu_announce_self_once(void *opaque)
         if (!nd_table[i].used)
             continue;
         len = announce_self_create(buf, nd_table[i].macaddr);
-        vlan = nd_table[i].vlan;
-        QTAILQ_FOREACH(vc, &vlan->clients, next) {
-            vc->receive(vc, buf, len);
-        }
+        qemu_send_packet_raw(nd_table[i].vc, buf, len);
     }
     if (--count) {
         /* delay 50ms, 150ms, 250ms, ... */