From: Ira Weiny <ira.weiny@intel.com>
Date: Tue, 25 May 2021 17:24:28 +0000 (-0700)
Subject: dax: Ensure errno is returned from dax_direct_access
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b05d4c576b697b9f462b9c532c997171d5c3b067;p=linux.git

dax: Ensure errno is returned from dax_direct_access

If the caller specifies a negative nr_pages that is an invalid
parameter.

Return -EINVAL to ensure callers get an errno if they want to check it.

Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Link: https://lore.kernel.org/r/20210525172428.3634316-4-ira.weiny@intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---

diff --git a/drivers/dax/super.c b/drivers/dax/super.c
index 5fa6ae9dbc8b0..44736cbd446ef 100644
--- a/drivers/dax/super.c
+++ b/drivers/dax/super.c
@@ -313,7 +313,7 @@ long dax_direct_access(struct dax_device *dax_dev, pgoff_t pgoff, long nr_pages,
 		return -ENXIO;
 
 	if (nr_pages < 0)
-		return nr_pages;
+		return -EINVAL;
 
 	avail = dax_dev->ops->direct_access(dax_dev, pgoff, nr_pages,
 			kaddr, pfn);