From: Thadeu Lima de Souza Cascardo Date: Fri, 1 Jul 2022 12:00:45 +0000 (-0300) Subject: objtool: skip non-text sections when adding return-thunk sites X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b0fb9784cf803472bbdcd3d98364c27966fee679;p=linux.git objtool: skip non-text sections when adding return-thunk sites The .discard.text section is added in order to reserve BRK, with a temporary function just so it can give it a size. This adds a relocation to the return thunk, which objtool will add to the .return_sites section. Linking will then fail as there are references to the .discard.text section. Do not add instructions from non-text sections to the list of return thunk calls, avoiding the reference to .discard.text. Signed-off-by: Thadeu Lima de Souza Cascardo Acked-by: Josh Poimboeuf Signed-off-by: Greg Kroah-Hartman --- diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 41d111c69620d..d80c54809a91d 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -1153,7 +1153,9 @@ static void add_return_call(struct objtool_file *file, struct instruction *insn) insn->type = INSN_RETURN; insn->retpoline_safe = true; - list_add_tail(&insn->call_node, &file->return_thunk_list); + /* Skip the non-text sections, specially .discard ones */ + if (insn->sec->text) + list_add_tail(&insn->call_node, &file->return_thunk_list); } /*