From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Fri, 30 Nov 2018 20:13:15 +0000 (-0800)
Subject: test_hexdump: use memcpy instead of strncpy
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b1286ed7158e9b62787508066283ab0b8850b518;p=linux.git

test_hexdump: use memcpy instead of strncpy

New versions of gcc reasonably warn about the odd pattern of

	strncpy(p, q, strlen(q));

which really doesn't make sense: the strncpy() ends up being just a slow
and odd way to write memcpy() in this case.

Apparently there was a patch for this floating around earlier, but it
got lost.

Acked-again-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/lib/test_hexdump.c b/lib/test_hexdump.c
index 626f580b4ff7b..5144899d3c6b8 100644
--- a/lib/test_hexdump.c
+++ b/lib/test_hexdump.c
@@ -99,7 +99,7 @@ static void __init test_hexdump_prepare_test(size_t len, int rowsize,
 		const char *q = *result++;
 		size_t amount = strlen(q);
 
-		strncpy(p, q, amount);
+		memcpy(p, q, amount);
 		p += amount;
 
 		*p++ = ' ';