From: Bo Liu Date: Wed, 1 Feb 2023 08:14:38 +0000 (-0500) Subject: net: dsa: Use sysfs_emit() to instead of sprintf() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b18ea3d9d214dfb23b0b6bd2acc121cb0d0fa2c5;p=linux.git net: dsa: Use sysfs_emit() to instead of sprintf() Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: Bo Liu Link: https://lore.kernel.org/r/20230201081438.3151-1-liubo03@inspur.com Signed-off-by: Paolo Abeni --- diff --git a/net/dsa/master.c b/net/dsa/master.c index 1507b8cdb3604..22d3f16b0e6db 100644 --- a/net/dsa/master.c +++ b/net/dsa/master.c @@ -299,7 +299,7 @@ static ssize_t tagging_show(struct device *d, struct device_attribute *attr, struct net_device *dev = to_net_dev(d); struct dsa_port *cpu_dp = dev->dsa_ptr; - return sprintf(buf, "%s\n", + return sysfs_emit(buf, "%s\n", dsa_tag_protocol_to_str(cpu_dp->tag_ops)); }