From: Kent Overstreet <kent.overstreet@linux.dev>
Date: Fri, 10 Nov 2023 04:43:35 +0000 (-0500)
Subject: bcachefs: Don't flush journal after replay
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b27d7afb791715f4017f94c58168676c76398986;p=linux.git

bcachefs: Don't flush journal after replay

The flush_all_pins() after journal replay was unecessary, and trying to
completely flush the journal while RW is not a great idea - it's not
guaranteed to terminate if other threads keep adding things to the
jorunal.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
---

diff --git a/fs/bcachefs/recovery.c b/fs/bcachefs/recovery.c
index 5cbef7ad8cc89..a588092241ca7 100644
--- a/fs/bcachefs/recovery.c
+++ b/fs/bcachefs/recovery.c
@@ -230,10 +230,8 @@ static int bch2_journal_replay(struct bch_fs *c)
 	j->replay_journal_seq = 0;
 
 	bch2_journal_set_replay_done(j);
-	bch2_journal_flush_all_pins(j);
-	ret = bch2_journal_error(j);
 
-	if (keys->nr && !ret)
+	if (keys->nr)
 		bch2_journal_log_msg(c, "journal replay finished");
 err:
 	if (trans)