From: Jianglei Nie Date: Mon, 5 Sep 2022 07:48:01 +0000 (+0800) Subject: HSI: ssi_protocol: fix potential resource leak in ssip_pn_open() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b28dbcb379e6a7f80262c2732a57681b1ee548ca;p=linux.git HSI: ssi_protocol: fix potential resource leak in ssip_pn_open() ssip_pn_open() claims the HSI client's port with hsi_claim_port(). When hsi_register_port_event() gets some error and returns a negetive value, the HSI client's port should be released with hsi_release_port(). Fix it by calling hsi_release_port() when hsi_register_port_event() fails. Signed-off-by: Jianglei Nie Signed-off-by: Sebastian Reichel --- diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c index 7aacb19fd1ffa..274ad8443f8c2 100644 --- a/drivers/hsi/clients/ssi_protocol.c +++ b/drivers/hsi/clients/ssi_protocol.c @@ -930,6 +930,7 @@ static int ssip_pn_open(struct net_device *dev) if (err < 0) { dev_err(&cl->device, "Register HSI port event failed (%d)\n", err); + hsi_release_port(cl); return err; } dev_dbg(&cl->device, "Configuring SSI port\n");