From: Chen Jiahao Date: Thu, 27 Jul 2023 13:16:35 +0000 (+0800) Subject: spi: s3c64xx: Clean up redundant dev_err_probe() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b2b561757027ef03b1243c828820a9004458194c;p=linux.git spi: s3c64xx: Clean up redundant dev_err_probe() Referring to platform_get_irq()'s definition, the return value has already been checked if ret < 0, and printed via dev_err_probe(). Calling dev_err_probe() one more time outside platform_get_irq() is obviously redundant. Removing dev_err_probe() outside platform_get_irq() to clean up above problem. Signed-off-by: Chen Jiahao Reviewed-by: Andi Shyti Link: https://lore.kernel.org/r/20230727131635.2898051-1-chenjiahao16@huawei.com Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index a1b68fdc205da..bf7cb18be9dc5 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1167,7 +1167,7 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) - return dev_err_probe(&pdev->dev, irq, "Failed to get IRQ\n"); + return irq; master = devm_spi_alloc_master(&pdev->dev, sizeof(*sdd)); if (!master)