From: Al Viro Date: Tue, 7 Nov 2023 17:35:37 +0000 (-0500) Subject: coda_flag_children(): cope with dentries turning negative X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b31559f8e471f402cd71117f35b9cde52d192138;p=linux.git coda_flag_children(): cope with dentries turning negative ->d_lock on parent does not stabilize ->d_inode of child. We don't do much with that inode in there, but we need at least to avoid struct inode getting freed under us... [rcu_read_lock() is not needed here, since parent's ->d_lock provides an rcu-critical area] Reviewed-by: Christian Brauner Signed-off-by: Al Viro --- diff --git a/fs/coda/cache.c b/fs/coda/cache.c index 3b8c4513118f4..d6254cf9f3972 100644 --- a/fs/coda/cache.c +++ b/fs/coda/cache.c @@ -94,12 +94,12 @@ static void coda_flag_children(struct dentry *parent, int flag) spin_lock(&parent->d_lock); list_for_each_entry(de, &parent->d_subdirs, d_child) { + struct inode *inode = d_inode_rcu(de); /* don't know what to do with negative dentries */ - if (d_inode(de) ) - coda_flag_inode(d_inode(de), flag); + if (inode) + coda_flag_inode(inode, flag); } spin_unlock(&parent->d_lock); - return; } void coda_flag_inode_children(struct inode *inode, int flag)