From: Richard Henderson <richard.henderson@linaro.org>
Date: Tue, 5 Mar 2024 20:15:50 +0000 (-1000)
Subject: linux-user/elfload: Don't close an unopened file descriptor
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b35348c7e62dc9b7caaabf3b45863ac119db9347;p=qemu.git

linux-user/elfload: Don't close an unopened file descriptor

Fixes Coverity CID: 1534964
Fixes: 106f8da664 ("linux-user/elfload: Open core file after vma_init")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 4dbca05646..26d4c1d6b3 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -4522,7 +4522,9 @@ static int elf_core_dump(int signr, const CPUArchState *env)
     ret = -errno;
     mmap_unlock();
     cpu_list_unlock();
-    close(fd);
+    if (fd >= 0) {
+        close(fd);
+    }
     return ret;
 }
 #endif /* USE_ELF_CORE_DUMP */