From: Sui Jingfeng Date: Tue, 8 Aug 2023 22:34:06 +0000 (+0800) Subject: PCI/VGA: Simplify vga_arbiter_notify_clients() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b421364a905e05d62f889786d25954c5a4128c80;p=linux.git PCI/VGA: Simplify vga_arbiter_notify_clients() In vga_arbiter_notify_clients(), "new_state" was computed during every loop iteration even though it doesn't depend on anything that changes during the loop. Move the computation outside the loop. [bhelgaas: drop renames that obscure the purpose, commit log] Link: https://lore.kernel.org/r/20230808223412.1743176-6-sui.jingfeng@linux.dev Signed-off-by: Sui Jingfeng Signed-off-by: Bjorn Helgaas --- diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c index 443cf1a74c0b1..685681b0e5afd 100644 --- a/drivers/pci/vgaarb.c +++ b/drivers/pci/vgaarb.c @@ -1477,12 +1477,10 @@ static void vga_arbiter_notify_clients(void) if (!vga_arbiter_used) return; + new_state = (vga_count > 1) ? false : true; + spin_lock_irqsave(&vga_lock, flags); list_for_each_entry(vgadev, &vga_list, list) { - if (vga_count > 1) - new_state = false; - else - new_state = true; if (vgadev->set_decode) { new_decodes = vgadev->set_decode(vgadev->pdev, new_state);