From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Date: Mon, 9 Oct 2023 19:02:52 +0000 (+0200)
Subject: bindings: python: replace PyModule_AddObjectRef() with PyModule_AddObject()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b436d05809b17ed734d08a36a8913eb687506433;p=qemu-gpiodev%2Flibgpiod.git

bindings: python: replace PyModule_AddObjectRef() with PyModule_AddObject()

PyModule_AddObjectRef() was added in cpython v3.10 while libgpiod claims
to depend on python v3.9. Replace it with an older variant that steals the
reference to the added object on success.

Reported-by: Phil Howard <phil@gadgetoid.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---

diff --git a/bindings/python/gpiod/ext/module.c b/bindings/python/gpiod/ext/module.c
index 25c252a..b456190 100644
--- a/bindings/python/gpiod/ext/module.c
+++ b/bindings/python/gpiod/ext/module.c
@@ -178,9 +178,9 @@ PyMODINIT_FUNC PyInit__ext(void)
 		return NULL;
 	}
 
-	ret = PyModule_AddObjectRef(module, "__all__", all);
-	Py_DECREF(all);
+	ret = PyModule_AddObject(module, "__all__", all);
 	if (ret) {
+		Py_DECREF(all);
 		Py_DECREF(module);
 		return NULL;
 	}