From: zhong jiang <zhongjiang@huawei.com>
Date: Sun, 16 Sep 2018 13:45:02 +0000 (+0800)
Subject: net: dsa: remove redundant null pointer check before put_device
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b458925ed5797a20f22cdf005625e25106cf7124;p=linux.git

net: dsa: remove redundant null pointer check before put_device

put_device has taken the null pinter check into account. So it is
safe to remove the duplicated check before put_device.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/dsa/legacy.c b/net/dsa/legacy.c
index 42a7b85b84e1f..8aa92b09db766 100644
--- a/net/dsa/legacy.c
+++ b/net/dsa/legacy.c
@@ -392,8 +392,7 @@ static void dsa_of_free_platform_data(struct dsa_platform_data *pd)
 		}
 
 		/* Drop our reference to the MDIO bus device */
-		if (pd->chip[i].host_dev)
-			put_device(pd->chip[i].host_dev);
+		put_device(pd->chip[i].host_dev);
 	}
 	kfree(pd->chip);
 }