From: David S. Miller <davem@davemloft.net>
Date: Mon, 25 Oct 2021 13:06:43 +0000 (+0100)
Subject: Merge branch 'ksettings-locking-fixes'
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b4ab21f90320969e5360719467153fc2bbc9435c;p=linux.git

Merge branch 'ksettings-locking-fixes'

Andrew Lunn says:

====================
ksettings_{get|set} lock fixes

Walter Stoll <Walter.Stoll@duagon.com> reported a race condition
between "ethtool -s eth0 speed 100 duplex full autoneg off" and phylib
reading the current status from the PHY. Both ksetting_get and
ksetting_set fail the take the phydev mutex, and as a result, there is
a small window of time where the phydev members are not self
consistent.

Patch 1 fixes phy_ethtool_ksettings_get by adding the needed lock.
Patches 2 and 3 move code around and perform to refactoring, to allow
patch 4 to fix phy_ethtool_ksettings_set by added the lock.

Thanks go to Walter for the detailed origional report, suggested fix,
and testing of the proposed patches.
====================

Signed-off-by: David S. Miller <davem@davemloft.net>
---

b4ab21f90320969e5360719467153fc2bbc9435c