From: Colin Ian King Date: Mon, 12 Apr 2021 16:10:12 +0000 (+0100) Subject: habanalabs/gaudi: Fix uninitialized return code rc when read size is zero X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b4e964f84c1a44b0c63a5036efb24cf0f938db0a;p=linux.git habanalabs/gaudi: Fix uninitialized return code rc when read size is zero In the case where size is zero the while loop never assigns rc and the return value is uninitialized. Fix this by initializing rc to zero. Fixes: 639781dcab82 ("habanalabs/gaudi: add debugfs to DMA from the device") Reviewed-by: Oded Gabbay Acked-by: Arnd Bergmann Signed-off-by: Colin Ian King Addresses-Coverity: ("Uninitialized scalar variable") Link: https://lore.kernel.org/r/20210412161012.1628202-1-colin.king@canonical.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c index 8730b691ec612..b751652f80a8c 100644 --- a/drivers/misc/habanalabs/gaudi/gaudi.c +++ b/drivers/misc/habanalabs/gaudi/gaudi.c @@ -6252,7 +6252,7 @@ static int gaudi_debugfs_read_dma(struct hl_device *hdev, u64 addr, u32 size, dma_addr_t dma_addr; void *kernel_addr; bool is_eng_idle; - int rc, dma_id; + int rc = 0, dma_id; kernel_addr = hdev->asic_funcs->asic_dma_alloc_coherent( hdev, SZ_2M,