From: Wang Jinchao Date: Wed, 31 Jan 2024 02:54:41 +0000 (+0800) Subject: fork: Using clone_flags for legacy clone check X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b639585e71e63008373d3a9fd060b87315fe7ea8;p=linux.git fork: Using clone_flags for legacy clone check In the current implementation of clone(), there is a line that initializes `u64 clone_flags = args->flags` at the top. This means that there is no longer a need to use args->flags for the legacy clone check. Signed-off-by: Wang Jinchao Link: https://lore.kernel.org/r/202401311054+0800-wangjinchao@xfusion.com Signed-off-by: Christian Brauner --- diff --git a/kernel/fork.c b/kernel/fork.c index 47ff3b35352e0..95647c66309f2 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -2875,8 +2875,8 @@ pid_t kernel_clone(struct kernel_clone_args *args) * here has the advantage that we don't need to have a separate helper * to check for legacy clone(). */ - if ((args->flags & CLONE_PIDFD) && - (args->flags & CLONE_PARENT_SETTID) && + if ((clone_flags & CLONE_PIDFD) && + (clone_flags & CLONE_PARENT_SETTID) && (args->pidfd == args->parent_tid)) return -EINVAL;