From: Linus Walleij <linus.walleij@linaro.org>
Date: Thu, 23 May 2019 22:11:43 +0000 (+0200)
Subject: pinctrl: core: Do not add device links for hogs
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b672a87ae5ab0704364781214bb1251b75cbef1b;p=linux.git

pinctrl: core: Do not add device links for hogs

Hogs would create circular device links, so do not link
the device to itself.

Cc: Benjamin Gaignard <benjamin.gaignard@st.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---

diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index d757c51d7114f..41adb4e47dc0e 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -1271,7 +1271,9 @@ static int pinctrl_commit_state(struct pinctrl *p, struct pinctrl_state *state)
 			goto unapply_new_state;
 		}
 
-		pinctrl_link_add(setting->pctldev, p->dev);
+		/* Do not link hogs (circular dependency) */
+		if (p != setting->pctldev->p)
+			pinctrl_link_add(setting->pctldev, p->dev);
 	}
 
 	p->state = state;