From: Ira Weiny <ira.weiny@intel.com>
Date: Tue, 20 Aug 2019 01:15:28 +0000 (-0700)
Subject: fs/xfs: Fix return code of xfs_break_leased_layouts()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b68271609c4f16a79eae8069933f64345afcf888;p=linux.git

fs/xfs: Fix return code of xfs_break_leased_layouts()

The parens used in the while loop would result in error being assigned
the value 1 rather than the intended errno value.

This is required to return -ETXTBSY from follow on break_layout()
changes.

Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---

diff --git a/fs/xfs/xfs_pnfs.c b/fs/xfs/xfs_pnfs.c
index 0c954cad74493..a339bd5fa2604 100644
--- a/fs/xfs/xfs_pnfs.c
+++ b/fs/xfs/xfs_pnfs.c
@@ -32,7 +32,7 @@ xfs_break_leased_layouts(
 	struct xfs_inode	*ip = XFS_I(inode);
 	int			error;
 
-	while ((error = break_layout(inode, false) == -EWOULDBLOCK)) {
+	while ((error = break_layout(inode, false)) == -EWOULDBLOCK) {
 		xfs_iunlock(ip, *iolock);
 		*did_unlock = true;
 		error = break_layout(inode, true);