From: Ding Xiang <dingxiang@cmss.chinamobile.com>
Date: Thu, 31 Aug 2023 09:31:44 +0000 (+0800)
Subject: selftests/mm: gup_longterm: fix a resource leak
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b6afcb94ce331b6d94dbeb56def173483993faf3;p=linux.git

selftests/mm: gup_longterm: fix a resource leak

The opened file should be closed in run_with_tmpfile(), otherwise resource
leak will occur

Link: https://lkml.kernel.org/r/20230831093144.7520-1-dingxiang@cmss.chinamobile.com
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c
index d33d3e68ffab8..ad168d35b23b7 100644
--- a/tools/testing/selftests/mm/gup_longterm.c
+++ b/tools/testing/selftests/mm/gup_longterm.c
@@ -265,10 +265,11 @@ static void run_with_tmpfile(test_fn fn, const char *desc)
 	fd = fileno(file);
 	if (fd < 0) {
 		ksft_test_result_fail("fileno() failed\n");
-		return;
+		goto close;
 	}
 
 	fn(fd, pagesize);
+close:
 	fclose(file);
 }