From: Yang Yingliang Date: Wed, 7 Apr 2021 09:17:06 +0000 (+0800) Subject: power: supply: generic-adc-battery: fix possible use-after-free in gab_remove() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b6cfa007b3b229771d9588970adb4ab3e0487f49;p=linux.git power: supply: generic-adc-battery: fix possible use-after-free in gab_remove() This driver's remove path calls cancel_delayed_work(). However, that function does not wait until the work function finishes. This means that the callback function may still be running after the driver's remove function has finished, which would result in a use-after-free. Fix by calling cancel_delayed_work_sync(), which ensures that the work is properly cancelled, no longer running, and unable to re-schedule itself. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Signed-off-by: Sebastian Reichel --- diff --git a/drivers/power/supply/generic-adc-battery.c b/drivers/power/supply/generic-adc-battery.c index 0032069fbc2bb..66039c665dd1e 100644 --- a/drivers/power/supply/generic-adc-battery.c +++ b/drivers/power/supply/generic-adc-battery.c @@ -373,7 +373,7 @@ static int gab_remove(struct platform_device *pdev) } kfree(adc_bat->psy_desc.properties); - cancel_delayed_work(&adc_bat->bat_work); + cancel_delayed_work_sync(&adc_bat->bat_work); return 0; }