From: Namjae Jeon <namjae.jeon@samsung.com>
Date: Wed, 26 May 2021 06:29:24 +0000 (+0900)
Subject: cifsd: set error return value for memcmp() difference
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b72802aa77dc2729b848057e96b6a2126182f75e;p=linux.git

cifsd: set error return value for memcmp() difference

Set error return value for memcmp() difference.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
---

diff --git a/fs/cifsd/auth.c b/fs/cifsd/auth.c
index ed32052fbf930..adfb3b33f2e55 100644
--- a/fs/cifsd/auth.c
+++ b/fs/cifsd/auth.c
@@ -430,7 +430,8 @@ int ksmbd_auth_ntlmv2(struct ksmbd_session *sess, struct ntlmv2_resp *ntlmv2,
 		goto out;
 	}
 
-	rc = memcmp(ntlmv2->ntlmv2_hash, ntlmv2_rsp, CIFS_HMAC_MD5_HASH_SIZE);
+	if (memcmp(ntlmv2->ntlmv2_hash, ntlmv2_rsp, CIFS_HMAC_MD5_HASH_SIZE) != 0)
+		rc = -EINVAL;
 out:
 	ksmbd_release_crypto_ctx(ctx);
 	kfree(construct);
@@ -469,7 +470,8 @@ static int __ksmbd_auth_ntlmv2(struct ksmbd_session *sess, char *client_nonce,
 		goto out;
 	}
 
-	rc = memcmp(ntlm_resp, key, CIFS_AUTH_RESP_SIZE);
+	if (memcmp(ntlm_resp, key, CIFS_AUTH_RESP_SIZE) != 0)
+		rc = -EINVAL;
 out:
 	return rc;
 }