From: Greg Kurz <groug@kaod.org>
Date: Mon, 6 Mar 2017 16:34:01 +0000 (+0100)
Subject: 9pfs: fix bogus fd check in local_remove()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b7361d46e75f12d8d943ca8d33ef82cafce39920;p=qemu.git

9pfs: fix bogus fd check in local_remove()

This was spotted by Coverity as a fd leak. This is certainly true, but also
local_remove() would always return without doing anything, unless the fd is
zero, which is very unlikely.

(Coverity issue CID1371732)

Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
---

diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
index f22a3c3654..5db7104334 100644
--- a/hw/9pfs/9p-local.c
+++ b/hw/9pfs/9p-local.c
@@ -1008,7 +1008,7 @@ static int local_remove(FsContext *ctx, const char *path)
     int err = -1;
 
     dirfd = local_opendir_nofollow(ctx, dirpath);
-    if (dirfd) {
+    if (dirfd == -1) {
         goto out;
     }