From: Sasha Finkelstein <fnkl.kernel@gmail.com>
Date: Fri, 10 Mar 2023 10:28:42 +0000 (+0100)
Subject: bluetooth: btbcm: Fix logic error in forming the board name.
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b76abe4648c1acc791a207e7c08d1719eb9f4ea8;p=linux.git

bluetooth: btbcm: Fix logic error in forming the board name.

This patch fixes an incorrect loop exit condition in code that replaces
'/' symbols in the board name. There might also be a memory corruption
issue here, but it is unlikely to be a real problem.

Cc: <stable@vger.kernel.org>
Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---

diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index 3006e2a0f37e1..43e98a598bd9a 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -511,7 +511,7 @@ static const char *btbcm_get_board_name(struct device *dev)
 	len = strlen(tmp) + 1;
 	board_type = devm_kzalloc(dev, len, GFP_KERNEL);
 	strscpy(board_type, tmp, len);
-	for (i = 0; i < board_type[i]; i++) {
+	for (i = 0; i < len; i++) {
 		if (board_type[i] == '/')
 			board_type[i] = '-';
 	}