From: Alexandre Belloni Date: Wed, 17 Apr 2024 19:19:35 +0000 (+0200) Subject: rtc: rx8111: demote warnings to debug level X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b7ff9efebc71eb7ded3ec2ce63e35a0675937fe1;p=linux.git rtc: rx8111: demote warnings to debug level The proper way for userspace to react on a read time error is to have a look at the voltage low information. There is no point in cluttering dmesg as it is often not even visible to the end user. Reviewed-by: Waqar Hameed Link: https://lore.kernel.org/r/20240417191937.33790-1-alexandre.belloni@bootlin.com Signed-off-by: Alexandre Belloni --- diff --git a/drivers/rtc/rtc-rx8111.c b/drivers/rtc/rtc-rx8111.c index 62d2352de1029..4a35bd921b334 100644 --- a/drivers/rtc/rtc-rx8111.c +++ b/drivers/rtc/rtc-rx8111.c @@ -170,14 +170,14 @@ static int rx8111_read_time(struct device *dev, struct rtc_time *tm) } if (FIELD_GET(RX8111_FLAG_XST_BIT, regval)) { - dev_warn(data->dev, - "Crystal oscillation stopped, time is not reliable\n"); + dev_dbg(data->dev, + "Crystal oscillation stopped, time is not reliable\n"); return -EINVAL; } if (FIELD_GET(RX8111_FLAG_VLF_BIT, regval)) { - dev_warn(data->dev, - "Low voltage detected, time is not reliable\n"); + dev_dbg(data->dev, + "Low voltage detected, time is not reliable\n"); return -EINVAL; } @@ -188,7 +188,7 @@ static int rx8111_read_time(struct device *dev, struct rtc_time *tm) } if (regval) { - dev_warn(data->dev, "Clock stopped, time is not reliable\n"); + dev_dbg(data->dev, "Clock stopped, time is not reliable\n"); return -EINVAL; }