From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Fri, 10 Mar 2023 22:41:23 +0000 (+0100)
Subject: bus: fsl-mc: Only warn once about errors on device unbind
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b816b9444c105b159ffc710579a204b75ed61261;p=linux.git

bus: fsl-mc: Only warn once about errors on device unbind

If a platform driver's remove function returns an error code, this
results in a (generic and little helpful) error message. Otherwise the
value is ignored.

As fsl_mc_driver_remove() already emit an error message, return 0 also
in the error case. The only effect is to suppress the device core's
error message.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Tested-by: Ioana Ciornei <ioana.ciornei@nxp.com> # sanity checks
Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Tested-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Li Yang <leoyang.li@nxp.com>
---

diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c
index 653e2d4c116f0..410693ff7335e 100644
--- a/drivers/bus/fsl-mc/fsl-mc-bus.c
+++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
@@ -457,10 +457,8 @@ static int fsl_mc_driver_remove(struct device *dev)
 	int error;
 
 	error = mc_drv->remove(mc_dev);
-	if (error < 0) {
+	if (error < 0)
 		dev_err(dev, "%s failed: %d\n", __func__, error);
-		return error;
-	}
 
 	return 0;
 }