From: Peter Maydell Date: Fri, 22 Jun 2018 12:28:42 +0000 (+0100) Subject: vl.c: Don't zero-initialize statics for serial_hds X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=b8d880ba6dcca098dc3a5d345a13bebdcce89c90;p=qemu.git vl.c: Don't zero-initialize statics for serial_hds checkpatch reminds us that statics shouldn't be zero-initialized: ERROR: do not initialise statics to 0 or NULL #35: FILE: vl.c:157: +static int num_serial_hds = 0; ERROR: do not initialise statics to 0 or NULL #36: FILE: vl.c:158: +static Chardev **serial_hds = NULL; I forgot to fix this in 6af2692e86f9fdfb3d; do so now. Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth Message-id: 20180426140253.3918-1-peter.maydell@linaro.org --- diff --git a/vl.c b/vl.c index b3426e03d0..d451f45dc5 100644 --- a/vl.c +++ b/vl.c @@ -151,8 +151,8 @@ QEMUClockType rtc_clock; int vga_interface_type = VGA_NONE; static DisplayOptions dpy; int no_frame; -static int num_serial_hds = 0; -static Chardev **serial_hds = NULL; +static int num_serial_hds; +static Chardev **serial_hds; Chardev *parallel_hds[MAX_PARALLEL_PORTS]; Chardev *virtcon_hds[MAX_VIRTIO_CONSOLES]; int win2k_install_hack = 0;