From: Igor Mammedov Date: Thu, 2 May 2019 14:52:03 +0000 (+0200) Subject: tests: acpi: print error unable to dump ACPI table during rebuild X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ba02ff90ee1dcaf7aa5645075217e555ae2c54ea;p=qemu.git tests: acpi: print error unable to dump ACPI table during rebuild Instead of just asserting print the error that lead to assert first. While at it move assert into rebuild branch, which removes redundant check done in case of !rebuild branch is taken (the later is taken care of by g_assert_no_error). Signed-off-by: Igor Mammedov Reviewed-by: Wei Yang Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1556808723-226478-16-git-send-email-imammedo@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index 39c1e24efd..11e07be093 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -195,11 +195,14 @@ static void dump_aml_files(test_data *data, bool rebuild) sdt->aml, ext); fd = g_open(aml_file, O_WRONLY|O_TRUNC|O_CREAT, S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP|S_IROTH); + if (fd < 0) { + perror(aml_file); + } + g_assert(fd >= 0); } else { fd = g_file_open_tmp("aml-XXXXXX", &sdt->aml_file, &error); g_assert_no_error(error); } - g_assert(fd >= 0); ret = qemu_write_full(fd, sdt->aml, sdt->aml_len); g_assert(ret == sdt->aml_len);