From: Lyude Paul Date: Fri, 19 Feb 2021 21:53:06 +0000 (-0500) Subject: drm/bridge/analogix/anx6345: Add missing drm_dp_aux_unregister() call X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ba5070ec16aeb673822309f9614fa36cca30259c;p=linux.git drm/bridge/analogix/anx6345: Add missing drm_dp_aux_unregister() call Another driver I found that seems to forget to unregister it's DP AUX device. Let's fix this by adding anx6345_bridge_detach(). Signed-off-by: Lyude Paul Reviewed-by: Robert Foss Link: https://patchwork.freedesktop.org/patch/msgid/20210219215326.2227596-11-lyude@redhat.com --- diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c index d9164fab044d0..8e016ba7c54af 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c @@ -574,6 +574,11 @@ static int anx6345_bridge_attach(struct drm_bridge *bridge, return 0; } +static void anx6345_bridge_detach(struct drm_bridge *bridge) +{ + drm_dp_aux_unregister(&bridge_to_anx6345(bridge)->aux); +} + static enum drm_mode_status anx6345_bridge_mode_valid(struct drm_bridge *bridge, const struct drm_display_info *info, @@ -624,6 +629,7 @@ static void anx6345_bridge_enable(struct drm_bridge *bridge) static const struct drm_bridge_funcs anx6345_bridge_funcs = { .attach = anx6345_bridge_attach, + .detach = anx6345_bridge_detach, .mode_valid = anx6345_bridge_mode_valid, .disable = anx6345_bridge_disable, .enable = anx6345_bridge_enable,