From: Rashika Kheria <rashika.kheria@gmail.com>
Date: Sat, 26 Oct 2013 17:41:22 +0000 (+0530)
Subject: Staging: dwc2: Fix conditional statement since urb->actual_length is never less than... 
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=bb6c3422c41274e7d36cb479ded104368687da9b;p=linux.git

Staging: dwc2: Fix conditional statement since urb->actual_length is never less than zero.

This patch fixes the following smatch warning in hcd.c:
drivers/staging/dwc2/hcd.c:787 dwc2_assign_and_init_hc() warn: unsigned 'urb->actual_length' is never less than zero.

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c
index 83629d84155d5..3cfd2d5152c92 100644
--- a/drivers/staging/dwc2/hcd.c
+++ b/drivers/staging/dwc2/hcd.c
@@ -784,8 +784,8 @@ static int dwc2_assign_and_init_hc(struct dwc2_hsotg *hsotg, struct dwc2_qh *qh)
 	chan->data_pid_start = qh->data_toggle;
 	chan->multi_count = 1;
 
-	if ((urb->actual_length < 0 || urb->actual_length > urb->length) &&
-	    !dwc2_hcd_is_pipe_in(&urb->pipe_info))
+	if (urb->actual_length > urb->length &&
+		!dwc2_hcd_is_pipe_in(&urb->pipe_info))
 		urb->actual_length = urb->length;
 
 	if (hsotg->core_params->dma_enable > 0) {