From: Javier Martinez Canillas Date: Fri, 22 Jul 2022 07:47:55 +0000 (+0200) Subject: drm/bridge: ti-sn65dsi86: Use dev_err_probe() to avoid polluting the log X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=bbb6f93f51a19787f455768015e9a77a4d83c4c8;p=linux.git drm/bridge: ti-sn65dsi86: Use dev_err_probe() to avoid polluting the log If devm_drm_of_get_bridge() can't find the connected bridge, it returns an ERR_PTR(-EPROBE_DEFER) to indicate that the probe should be deferred. But this path also prints an error message, which pollutes the kernel log since is printed on every probe deferral, i.e: $ dmesg | grep "failed to create panel bridge" | wc -l 38 Signed-off-by: Javier Martinez Canillas Reviewed-by: Neil Armstrong Reviewed-by: Andrzej Hajda Reviewed-by: Douglas Anderson Link: https://patchwork.freedesktop.org/patch/msgid/20220722074755.660258-1-javierm@redhat.com --- diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 369bf72717f66..90bbabde15959 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -1206,10 +1206,9 @@ static int ti_sn_bridge_probe(struct auxiliary_device *adev, int ret; pdata->next_bridge = devm_drm_of_get_bridge(pdata->dev, np, 1, 0); - if (IS_ERR(pdata->next_bridge)) { - DRM_ERROR("failed to create panel bridge\n"); - return PTR_ERR(pdata->next_bridge); - } + if (IS_ERR(pdata->next_bridge)) + return dev_err_probe(pdata->dev, PTR_ERR(pdata->next_bridge), + "failed to create panel bridge\n"); ti_sn_bridge_parse_lanes(pdata, np);