From: Guenter Roeck <linux@roeck-us.net>
Date: Sat, 9 May 2020 20:13:33 +0000 (-0700)
Subject: hwmon: (drivetemp) Fix SCT support if SCT data tables are not supported
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=bcb543cc3d4034da3f3fd8bc4296a26dfeadf47d;p=linux.git

hwmon: (drivetemp) Fix SCT support if SCT data tables are not supported

If SCT is supported but SCT data tables are not, the driver unnecessarily
tries to fall back to SMART. Use SCT without data tables instead in this
situation.

Fixes: 5b46903d8bf3 ("hwmon: Driver for disk and solid state drives with temperature sensors")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---

diff --git a/drivers/hwmon/drivetemp.c b/drivers/hwmon/drivetemp.c
index 9179460c2d9d5..0d4f3d97ffc61 100644
--- a/drivers/hwmon/drivetemp.c
+++ b/drivers/hwmon/drivetemp.c
@@ -346,7 +346,7 @@ static int drivetemp_identify_sata(struct drivetemp_data *st)
 	st->have_temp_highest = temp_is_valid(buf[SCT_STATUS_TEMP_HIGHEST]);
 
 	if (!have_sct_data_table)
-		goto skip_sct;
+		goto skip_sct_data;
 
 	/* Request and read temperature history table */
 	memset(buf, '\0', sizeof(st->smartdata));