From: Miaoqian Lin Date: Mon, 7 Mar 2022 10:51:35 +0000 (+0000) Subject: tty: serial: owl: Fix missing clk_disable_unprepare() in owl_uart_probe X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=bcea0f547ec1a2ee44d429aaf0334633e386e67c;p=linux.git tty: serial: owl: Fix missing clk_disable_unprepare() in owl_uart_probe Fix the missing clk_disable_unprepare() before return from owl_uart_probe() in the error handling case. Fixes: abf42d2f333b ("tty: serial: owl: add "much needed" clk_prepare_enable()") Signed-off-by: Miaoqian Lin Link: https://lore.kernel.org/r/20220307105135.11698-1-linmq006@gmail.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/owl-uart.c b/drivers/tty/serial/owl-uart.c index 5ff7c89aeb065..44d20e5a7dd35 100644 --- a/drivers/tty/serial/owl-uart.c +++ b/drivers/tty/serial/owl-uart.c @@ -731,6 +731,7 @@ static int owl_uart_probe(struct platform_device *pdev) owl_port->port.uartclk = clk_get_rate(owl_port->clk); if (owl_port->port.uartclk == 0) { dev_err(&pdev->dev, "clock rate is zero\n"); + clk_disable_unprepare(owl_port->clk); return -EINVAL; } owl_port->port.flags = UPF_BOOT_AUTOCONF | UPF_IOREMAP | UPF_LOW_LATENCY;