From: Jan Kara <jack@suse.cz>
Date: Tue, 3 Oct 2023 09:19:02 +0000 (+0200)
Subject: udf: Avoid unneeded variable length array in struct fileIdentDesc
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=bceef326bc87781abb5139898d5f2807881194d9;p=linux.git

udf: Avoid unneeded variable length array in struct fileIdentDesc

impUse variable length array in struct fileIdentDesc is never used.
It serves only for documentation purposes of the on-disk format. Remove
it from the struct so that it doesn't confuse the compiler and
reviewers.

Reported-by: "Gustavo A. R. Silva" <gustavoars@kernel.org>
References: https://lore.kernel.org/all/ZRrsYkKIQe8K6F/t@work
Signed-off-by: Jan Kara <jack@suse.cz>
---

diff --git a/fs/udf/ecma_167.h b/fs/udf/ecma_167.h
index de17a97e86674..415b050b977d2 100644
--- a/fs/udf/ecma_167.h
+++ b/fs/udf/ecma_167.h
@@ -471,7 +471,7 @@ struct fileIdentDesc {
 	uint8_t		lengthFileIdent;
 	struct long_ad	icb;
 	__le16		lengthOfImpUse;
-	uint8_t		impUse[];
+	/* uint8_t	impUse[]; */
 	/* uint8_t	fileIdent[]; */
 	/* uint8_t	padding[]; */
 } __packed;