From: Mark Cave-Ayland Date: Sun, 15 Oct 2017 09:05:59 +0000 (+0100) Subject: sun4u: fix assert when adding NICs which aren't the in-built model X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=bcf9e2c2f2b7a610efaafc4bd6d0bee9181c2345;p=qemu.git sun4u: fix assert when adding NICs which aren't the in-built model Commit 8d93297 introduced a bug whereby non-inbuilt NICs are realized before setting the default MAC address causing an assert. Switch NIC creation over from pci_create_simple() to pci_create() which works exactly the same except omitting the realize as originally intended. Signed-off-by: Mark Cave-Ayland Reviewed-by: Artyom Tarasenko --- diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index 55d81ee73e..77a787466a 100644 --- a/hw/sparc64/sun4u.c +++ b/hw/sparc64/sun4u.c @@ -494,10 +494,10 @@ static void sun4uv_init(MemoryRegion *address_space_mem, memcpy(&macaddr, &nd->macaddr.a, sizeof(MACAddr)); onboard_nic = true; } else { - pci_dev = pci_create_simple(pci_busB, -1, "sunhme"); + pci_dev = pci_create(pci_busB, -1, "sunhme"); } } else { - pci_dev = pci_create_simple(pci_busB, -1, nd->model); + pci_dev = pci_create(pci_busB, -1, nd->model); } dev = &pci_dev->qdev;