From: Mike Christie Date: Thu, 2 Jul 2020 01:43:22 +0000 (-0500) Subject: scsi: target: Fix iscsi transport id buf len calculation X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=bd7f65d952007adceceecece39705bb3a1b55f90;p=linux.git scsi: target: Fix iscsi transport id buf len calculation The isid returned to the initiator is in string format which is 12 bytes. We also only add 1 terminating NULL and not one after the initiator name and another one after the isid. Link: https://lore.kernel.org/r/1593654203-12442-7-git-send-email-michael.christie@oracle.com Signed-off-by: Mike Christie Signed-off-by: Martin K. Petersen --- diff --git a/drivers/target/target_core_fabric_lib.c b/drivers/target/target_core_fabric_lib.c index 428e5a1d7e204..1d2762a99c028 100644 --- a/drivers/target/target_core_fabric_lib.c +++ b/drivers/target/target_core_fabric_lib.c @@ -234,7 +234,7 @@ static int iscsi_get_pr_transport_id_len( */ if (pr_reg->isid_present_at_reg) { len += 5; /* For ",i,0x" ASCII separator */ - len += 7; /* For iSCSI Initiator Session ID + Null terminator */ + len += 12; /* For iSCSI Initiator Session ID */ *format_code = 1; } else *format_code = 0;