From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Date: Fri, 13 Oct 2023 07:43:55 +0000 (+0200)
Subject: media: pci: cx18: if cx == NULL, then don't use it.
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=be521bf7bfad4e4bd4c3e1d2853aeb563a1e51d6;p=linux.git

media: pci: cx18: if cx == NULL, then don't use it.

If the cx NULL pointer check is true, then it reports
an error with CX18_ERR, but that uses cx. Replace it with
pr_err.

Reported by smatch:

drivers/media/pci/cx18/cx18-mailbox.c:834 cx18_vapi() error: we previously assumed 'cx' could be null (see line 833)

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---

diff --git a/drivers/media/pci/cx18/cx18-mailbox.c b/drivers/media/pci/cx18/cx18-mailbox.c
index 3b283f3c67268..a6457c23d18c9 100644
--- a/drivers/media/pci/cx18/cx18-mailbox.c
+++ b/drivers/media/pci/cx18/cx18-mailbox.c
@@ -831,7 +831,7 @@ int cx18_vapi(struct cx18 *cx, u32 cmd, int args, ...)
 	int i;
 
 	if (cx == NULL) {
-		CX18_ERR("cx == NULL (cmd=%x)\n", cmd);
+		pr_err("cx == NULL (cmd=%x)\n", cmd);
 		return 0;
 	}
 	if (args > MAX_MB_ARGUMENTS) {