From: Danilo Krummrich Date: Fri, 1 Jul 2022 18:53:00 +0000 (+0200) Subject: drm/sis: use idr_init_base() to initialize dev_priv->object_idr X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=bf8afc2090795b8640bf1842529627e69f673df4;p=linux.git drm/sis: use idr_init_base() to initialize dev_priv->object_idr idr_init_base(), implemented by commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient"), let us set an arbitrary base other than idr_init(), which uses base 0. Since, for this IDR, no ID < 1 is ever requested/allocated, using idr_init_base(&idr, 1) avoids unnecessary tree walks. Signed-off-by: Danilo Krummrich Signed-off-by: Maxime Ripard Link: https://lore.kernel.org/r/20220701185303.284082-8-dakr@redhat.com --- diff --git a/drivers/gpu/drm/sis/sis_drv.c b/drivers/gpu/drm/sis/sis_drv.c index e35e719cf315b..6173020a9bf56 100644 --- a/drivers/gpu/drm/sis/sis_drv.c +++ b/drivers/gpu/drm/sis/sis_drv.c @@ -50,7 +50,7 @@ static int sis_driver_load(struct drm_device *dev, unsigned long chipset) if (dev_priv == NULL) return -ENOMEM; - idr_init(&dev_priv->object_idr); + idr_init_base(&dev_priv->object_idr, 1); dev->dev_private = (void *)dev_priv; dev_priv->chipset = chipset;