From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Thu, 17 Jun 2021 09:51:40 +0000 (+0200)
Subject: pwm: tegra: Drop an if block with an always false condition
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=c1b8ac969febc8f413c4d71f0eefe2e107610449;p=linux.git

pwm: tegra: Drop an if block with an always false condition

tegra_pwm_remove() is only called after tegra_pwm_probe() successfully
completed. In this case platform_set_drvdata() was called with a
non-NULL value and so platform_get_drvdata(pdev) cannot return NULL.

Returning an error code from a platform_driver's remove function is
ignored anyway, so it's a good thing this exit path is gone.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
---

diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c
index c529a170bcdd1..fa025795198b6 100644
--- a/drivers/pwm/pwm-tegra.c
+++ b/drivers/pwm/pwm-tegra.c
@@ -303,9 +303,6 @@ static int tegra_pwm_remove(struct platform_device *pdev)
 	unsigned int i;
 	int err;
 
-	if (WARN_ON(!pc))
-		return -ENODEV;
-
 	err = clk_prepare_enable(pc->clk);
 	if (err < 0)
 		return err;