From: Ulf Hansson <ulf.hansson@linaro.org>
Date: Wed, 6 Mar 2019 14:04:52 +0000 (+0100)
Subject: mmc: mmci: Drop unnecessary clear of variant->qcom_dml flag
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=c21aa7a804160f58e391c9fcb2aff16e7d30c80f;p=linux.git

mmc: mmci: Drop unnecessary clear of variant->qcom_dml flag

There's no point clearing the variant flag in case the qcom variant fails
to setup DMA. This is because if mmci_dma_setup() fails, then the use_dma
flag remains set to false, which leads to mmci using PIO mode and not DMA.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
---

diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c
index 25d0a75533eaa..b942d4aeeb774 100644
--- a/drivers/mmc/host/mmci_qcom_dml.c
+++ b/drivers/mmc/host/mmci_qcom_dml.c
@@ -133,7 +133,6 @@ static int qcom_dma_setup(struct mmci_host *host)
 	producer_id = of_get_dml_pipe_index(np, "rx");
 
 	if (producer_id < 0 || consumer_id < 0) {
-		host->variant->qcom_dml = false;
 		mmci_dmae_release(host);
 		return -EINVAL;
 	}