From: Gustavo A. R. Silva <gustavo@embeddedor.com>
Date: Wed, 3 Oct 2018 12:33:28 +0000 (+0200)
Subject: spi: slave: Fix missing break in switch
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=c24bfa8f21b59283580043dada19a6e943b6e426;p=linux.git

spi: slave: Fix missing break in switch

Apparently, this code does not actually fall through to the next case
because the machine restarts before it has a chance. However, for the
sake of maintenance and readability, we better add the missing break
statement.

Addresses-Coverity-ID: 1437892 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---

diff --git a/drivers/spi/spi-slave-system-control.c b/drivers/spi/spi-slave-system-control.c
index c0257e937995e..169f3d595f60c 100644
--- a/drivers/spi/spi-slave-system-control.c
+++ b/drivers/spi/spi-slave-system-control.c
@@ -60,6 +60,7 @@ static void spi_slave_system_control_complete(void *arg)
 	case CMD_REBOOT:
 		dev_info(&priv->spi->dev, "Rebooting system...\n");
 		kernel_restart(NULL);
+		break;
 
 	case CMD_POWEROFF:
 		dev_info(&priv->spi->dev, "Powering off system...\n");