From: Uwe Kleine-König Date: Thu, 14 Jan 2021 17:57:16 +0000 (+0100) Subject: tty: hvcs: Drop unnecessary if block X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=c24dc4bab20c88bd8f493e0339b8cc65df828acd;p=linux.git tty: hvcs: Drop unnecessary if block If hvcs_probe() succeeded dev_set_drvdata() is called with a non-NULL value, and if hvcs_probe() failed hvcs_remove() isn't called. So there is no way dev_get_drvdata() can return NULL in hvcs_remove() and the check can just go away. Reviewed-by: Jiri Slaby Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20210114175718.137483-2-u.kleine-koenig@pengutronix.de Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c index dfe02283ed230..c908489196442 100644 --- a/drivers/tty/hvc/hvcs.c +++ b/drivers/tty/hvc/hvcs.c @@ -825,9 +825,6 @@ static int hvcs_remove(struct vio_dev *dev) unsigned long flags; struct tty_struct *tty; - if (!hvcsd) - return -ENODEV; - /* By this time the vty-server won't be getting any more interrupts */ spin_lock_irqsave(&hvcsd->lock, flags);