From: J. Bruce Fields <bfields@redhat.com>
Date: Wed, 3 Jun 2020 15:12:32 +0000 (-0400)
Subject: nfsd: safer handling of corrupted c_type
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=c25bf185e57213b54ea0d632ac04907310993433;p=linux.git

nfsd: safer handling of corrupted c_type

This can only happen if there's a bug somewhere, so let's make it a WARN
not a printk.  Also, I think it's safest to ignore the corruption rather
than trying to fix it by removing a cache entry.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---

diff --git a/fs/nfsd/nfscache.c b/fs/nfsd/nfscache.c
index f30a7def78996..0a0cf1fd77d33 100644
--- a/fs/nfsd/nfscache.c
+++ b/fs/nfsd/nfscache.c
@@ -477,8 +477,7 @@ found_entry:
 		rtn = RC_REPLY;
 		break;
 	default:
-		printk(KERN_WARNING "nfsd: bad repcache type %d\n", rp->c_type);
-		nfsd_reply_cache_free_locked(b, rp, nn);
+		WARN_ONCE(1, "nfsd: bad repcache type %d\n", rp->c_type);
 	}
 
 out_trace: