From: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Date: Mon, 17 Jul 2023 14:39:23 +0000 (+0530)
Subject: cgroup: remove cgrp->kn check in css_populate_dir()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=c25ff4b911a11908c7f05bc07cc6762f9cece2b5;p=linux.git

cgroup: remove cgrp->kn check in css_populate_dir()

cgroup_create() creates cgrp and assigns the kernfs_node to cgrp->kn,
then cgroup_mkdir() populates base and csses cft file by calling
css_populate_dir() and cgroup_apply_control_enable() with a valid
cgrp->kn. Check for NULL cgrp->kn, will always be false, remove it.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
---

diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index aa2cc32e60c0a..3c1bb9ecea105 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -1714,7 +1714,7 @@ static int css_populate_dir(struct cgroup_subsys_state *css)
 	struct cftype *cfts, *failed_cfts;
 	int ret;
 
-	if ((css->flags & CSS_VISIBLE) || !cgrp->kn)
+	if (css->flags & CSS_VISIBLE)
 		return 0;
 
 	if (!css->ss) {