From: Uwe Kleine-König Date: Sun, 7 Feb 2021 21:55:55 +0000 (+0100) Subject: ipack: Fail earlier for drivers without probe function X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=c31d32ba580d2f361e6169c093fdf624e5851925;p=linux.git ipack: Fail earlier for drivers without probe function A driver without a probe function isn't useful as it can never be used. Let registering such a driver fail already instead of failing every binding. This is only cosmetic as there is no ipack driver without a probe function. Signed-off-by: Uwe Kleine-König Acked-by: Samuel Iglesias Gonsalvez Link: https://lore.kernel.org/r/20210207215556.96371-1-uwe@kleine-koenig.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c index 9267a85fee186..eabc4d08792af 100644 --- a/drivers/ipack/ipack.c +++ b/drivers/ipack/ipack.c @@ -64,9 +64,6 @@ static int ipack_bus_probe(struct device *device) struct ipack_device *dev = to_ipack_dev(device); struct ipack_driver *drv = to_ipack_driver(device->driver); - if (!drv->ops->probe) - return -EINVAL; - return drv->ops->probe(dev); } @@ -252,6 +249,9 @@ EXPORT_SYMBOL_GPL(ipack_bus_unregister); int ipack_driver_register(struct ipack_driver *edrv, struct module *owner, const char *name) { + if (!edrv->ops->probe) + return -EINVAL; + edrv->driver.owner = owner; edrv->driver.name = name; edrv->driver.bus = &ipack_bus_type;