From: Max Filippov Date: Mon, 3 Jul 2023 16:57:25 +0000 (-0700) Subject: xtensa: ISS: add comment about etherdev freeing X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=c44e783e0b4539cb8296da9229202a9f9e6a3c8d;p=linux.git xtensa: ISS: add comment about etherdev freeing iss_net_configure explicitly frees etherdev in all error return paths except one where register_netdevice fails. In that remaining error return path the etherdev is freed by the iss_net_pdev_release callback triggered by the platform_device_unregister call. Add a comment stating that. Signed-off-by: Max Filippov --- diff --git a/arch/xtensa/platforms/iss/network.c b/arch/xtensa/platforms/iss/network.c index 9ac46ab3a296c..7b97e6ab85a42 100644 --- a/arch/xtensa/platforms/iss/network.c +++ b/arch/xtensa/platforms/iss/network.c @@ -540,6 +540,7 @@ static void iss_net_configure(int index, char *init) rtnl_unlock(); pr_err("%s: error registering net device!\n", dev->name); platform_device_unregister(&lp->pdev); + /* dev is freed by the iss_net_pdev_release callback */ return; } rtnl_unlock();